Skip to content

fix(pglite-sync): accept liveSse shape option#1045

Open
sjh9714 wants to merge 1 commit into
electric-sql:mainfrom
sjh9714:fix-pglite-sync-live-sse
Open

fix(pglite-sync): accept liveSse shape option#1045
sjh9714 wants to merge 1 commit into
electric-sql:mainfrom
sjh9714:fix-pglite-sync-live-sse

Conversation

@sjh9714

@sjh9714 sjh9714 commented Jul 2, 2026

Copy link
Copy Markdown

Summary

Fixes #861.

@electric-sql/pglite-sync now accepts the documented liveSse shape option and maps it to the current Electric client experimentalLiveSse option before creating the multi-shape stream. Existing explicit experimentalLiveSse values continue to take precedence.

Changes

  • Add a small pglite-sync shape option normalizer for liveSse.
  • Use the normalized options when constructing sync shape streams.
  • Add focused regression coverage for liveSse mapping and precedence.
  • Add the required changeset.

Testing

  • pnpm install --frozen-lockfile
  • pnpm --filter @electric-sql/pglite-sync test -- --run test/shapeStreamOptions.test.ts
  • pnpm --filter @electric-sql/pglite-sync lint
  • git diff --check

Verification gap: pnpm --filter @electric-sql/pglite-sync build, pnpm --filter @electric-sql/pglite-sync typecheck, and the existing test/sync.test.ts path could not complete in this local checkout because the generated @electric-sql/pglite package artifacts/types were not present.

Note: I used Codex while preparing this change, reviewed the final diff, and ran the checks listed above locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Missing liveSse from ShapeStreamOptions in pglite-sync

1 participant