fix(pglite-sync): accept liveSse shape option#1045
Open
sjh9714 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #861.
@electric-sql/pglite-syncnow accepts the documentedliveSseshape option and maps it to the current Electric clientexperimentalLiveSseoption before creating the multi-shape stream. Existing explicitexperimentalLiveSsevalues continue to take precedence.Changes
liveSse.liveSsemapping and precedence.Testing
pnpm install --frozen-lockfilepnpm --filter @electric-sql/pglite-sync test -- --run test/shapeStreamOptions.test.tspnpm --filter @electric-sql/pglite-sync lintgit diff --checkVerification gap:
pnpm --filter @electric-sql/pglite-sync build,pnpm --filter @electric-sql/pglite-sync typecheck, and the existingtest/sync.test.tspath could not complete in this local checkout because the generated@electric-sql/pglitepackage artifacts/types were not present.Note: I used Codex while preparing this change, reviewed the final diff, and ran the checks listed above locally.